Skip to content

Commit 4d24ef5

Browse files
fix(core): bump Pigeon to v25.3.2 (#17438)
* fix(core): bump Pigeon to v25.3.2 * fix: header should be available for SPM/cocoapods * chore: update to new naming types * chore(ios): update naming to match pigeon messages * chore: update to iOS 13 min * chore: move android over to latest Pigeon API * chore: update windows types to match latest * chore: update macOS version * apple example config * format * format * chore: fix unit test types * chore: update response from initializeCore * chore: rm unneeded check from response
1 parent 6b78b5d commit 4d24ef5

File tree

27 files changed

+1380
-796
lines changed

27 files changed

+1380
-796
lines changed

packages/firebase_ai/firebase_ai/test/mock.dart

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,23 +20,23 @@ import 'package:plugin_platform_interface/plugin_platform_interface.dart';
2020

2121
class MockFirebaseAppVertexAI implements TestFirebaseCoreHostApi {
2222
@override
23-
Future<PigeonInitializeResponse> initializeApp(
23+
Future<CoreInitializeResponse> initializeApp(
2424
String appName,
25-
PigeonFirebaseOptions initializeAppRequest,
25+
CoreFirebaseOptions initializeAppRequest,
2626
) async {
27-
return PigeonInitializeResponse(
27+
return CoreInitializeResponse(
2828
name: appName,
2929
options: initializeAppRequest,
3030
pluginConstants: {},
3131
);
3232
}
3333

3434
@override
35-
Future<List<PigeonInitializeResponse?>> initializeCore() async {
35+
Future<List<CoreInitializeResponse>> initializeCore() async {
3636
return [
37-
PigeonInitializeResponse(
37+
CoreInitializeResponse(
3838
name: defaultFirebaseAppName,
39-
options: PigeonFirebaseOptions(
39+
options: CoreFirebaseOptions(
4040
apiKey: '123',
4141
projectId: '123',
4242
appId: '123',
@@ -48,8 +48,8 @@ class MockFirebaseAppVertexAI implements TestFirebaseCoreHostApi {
4848
}
4949

5050
@override
51-
Future<PigeonFirebaseOptions> optionsFromResource() async {
52-
return PigeonFirebaseOptions(
51+
Future<CoreFirebaseOptions> optionsFromResource() async {
52+
return CoreFirebaseOptions(
5353
apiKey: '123',
5454
projectId: '123',
5555
appId: '123',
@@ -61,7 +61,7 @@ class MockFirebaseAppVertexAI implements TestFirebaseCoreHostApi {
6161
void setupFirebaseVertexAIMocks() {
6262
TestWidgetsFlutterBinding.ensureInitialized();
6363

64-
TestFirebaseCoreHostApi.setup(MockFirebaseAppVertexAI());
64+
TestFirebaseCoreHostApi.setUp(MockFirebaseAppVertexAI());
6565
}
6666

6767
// FirebaseVertexAIPlatform Mock

packages/firebase_core/firebase_core/android/src/main/java/io/flutter/plugins/firebase/core/FlutterFirebaseCorePlugin.java

Lines changed: 43 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,22 @@ public class FlutterFirebaseCorePlugin
3535

3636
@Override
3737
public void onAttachedToEngine(FlutterPluginBinding binding) {
38-
GeneratedAndroidFirebaseCore.FirebaseCoreHostApi.setup(binding.getBinaryMessenger(), this);
39-
GeneratedAndroidFirebaseCore.FirebaseAppHostApi.setup(binding.getBinaryMessenger(), this);
38+
GeneratedAndroidFirebaseCore.FirebaseCoreHostApi.setUp(binding.getBinaryMessenger(), this);
39+
GeneratedAndroidFirebaseCore.FirebaseAppHostApi.setUp(binding.getBinaryMessenger(), this);
4040
applicationContext = binding.getApplicationContext();
4141
}
4242

4343
@Override
4444
public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) {
4545
applicationContext = null;
46-
GeneratedAndroidFirebaseCore.FirebaseCoreHostApi.setup(binding.getBinaryMessenger(), null);
47-
GeneratedAndroidFirebaseCore.FirebaseAppHostApi.setup(binding.getBinaryMessenger(), null);
46+
GeneratedAndroidFirebaseCore.FirebaseCoreHostApi.setUp(binding.getBinaryMessenger(), null);
47+
GeneratedAndroidFirebaseCore.FirebaseAppHostApi.setUp(binding.getBinaryMessenger(), null);
4848
}
4949

50-
private GeneratedAndroidFirebaseCore.PigeonFirebaseOptions firebaseOptionsToMap(
50+
private GeneratedAndroidFirebaseCore.CoreFirebaseOptions firebaseOptionsToMap(
5151
FirebaseOptions options) {
52-
GeneratedAndroidFirebaseCore.PigeonFirebaseOptions.Builder firebaseOptions =
53-
new GeneratedAndroidFirebaseCore.PigeonFirebaseOptions.Builder();
52+
GeneratedAndroidFirebaseCore.CoreFirebaseOptions.Builder firebaseOptions =
53+
new GeneratedAndroidFirebaseCore.CoreFirebaseOptions.Builder();
5454

5555
firebaseOptions.setApiKey(options.getApiKey());
5656
firebaseOptions.setAppId(options.getApplicationId());
@@ -67,16 +67,16 @@ private GeneratedAndroidFirebaseCore.PigeonFirebaseOptions firebaseOptionsToMap(
6767
return firebaseOptions.build();
6868
}
6969

70-
private Task<GeneratedAndroidFirebaseCore.PigeonInitializeResponse> firebaseAppToMap(
70+
private Task<GeneratedAndroidFirebaseCore.CoreInitializeResponse> firebaseAppToMap(
7171
FirebaseApp firebaseApp) {
72-
TaskCompletionSource<GeneratedAndroidFirebaseCore.PigeonInitializeResponse>
73-
taskCompletionSource = new TaskCompletionSource<>();
72+
TaskCompletionSource<GeneratedAndroidFirebaseCore.CoreInitializeResponse> taskCompletionSource =
73+
new TaskCompletionSource<>();
7474

7575
cachedThreadPool.execute(
7676
() -> {
7777
try {
78-
GeneratedAndroidFirebaseCore.PigeonInitializeResponse.Builder initializeResponse =
79-
new GeneratedAndroidFirebaseCore.PigeonInitializeResponse.Builder();
78+
GeneratedAndroidFirebaseCore.CoreInitializeResponse.Builder initializeResponse =
79+
new GeneratedAndroidFirebaseCore.CoreInitializeResponse.Builder();
8080

8181
initializeResponse.setName(firebaseApp.getName());
8282
initializeResponse.setOptions(firebaseOptionsToMap(firebaseApp.getOptions()));
@@ -111,14 +111,30 @@ private <T> void listenToResponse(
111111
});
112112
}
113113

114+
private void listenToVoidResponse(
115+
TaskCompletionSource<Void> taskCompletionSource,
116+
GeneratedAndroidFirebaseCore.VoidResult result) {
117+
taskCompletionSource
118+
.getTask()
119+
.addOnCompleteListener(
120+
task -> {
121+
if (task.isSuccessful()) {
122+
result.success();
123+
} else {
124+
Exception exception = task.getException();
125+
result.error(exception);
126+
}
127+
});
128+
}
129+
114130
@Override
115131
public void initializeApp(
116132
@NonNull String appName,
117-
@NonNull GeneratedAndroidFirebaseCore.PigeonFirebaseOptions initializeAppRequest,
118-
GeneratedAndroidFirebaseCore.Result<GeneratedAndroidFirebaseCore.PigeonInitializeResponse>
133+
@NonNull GeneratedAndroidFirebaseCore.CoreFirebaseOptions initializeAppRequest,
134+
GeneratedAndroidFirebaseCore.Result<GeneratedAndroidFirebaseCore.CoreInitializeResponse>
119135
result) {
120-
TaskCompletionSource<GeneratedAndroidFirebaseCore.PigeonInitializeResponse>
121-
taskCompletionSource = new TaskCompletionSource<>();
136+
TaskCompletionSource<GeneratedAndroidFirebaseCore.CoreInitializeResponse> taskCompletionSource =
137+
new TaskCompletionSource<>();
122138

123139
cachedThreadPool.execute(
124140
() -> {
@@ -160,10 +176,9 @@ public void initializeApp(
160176

161177
@Override
162178
public void initializeCore(
163-
GeneratedAndroidFirebaseCore.Result<
164-
List<GeneratedAndroidFirebaseCore.PigeonInitializeResponse>>
179+
GeneratedAndroidFirebaseCore.Result<List<GeneratedAndroidFirebaseCore.CoreInitializeResponse>>
165180
result) {
166-
TaskCompletionSource<List<GeneratedAndroidFirebaseCore.PigeonInitializeResponse>>
181+
TaskCompletionSource<List<GeneratedAndroidFirebaseCore.CoreInitializeResponse>>
167182
taskCompletionSource = new TaskCompletionSource<>();
168183

169184
cachedThreadPool.execute(
@@ -176,7 +191,7 @@ public void initializeCore(
176191
}
177192

178193
List<FirebaseApp> firebaseApps = FirebaseApp.getApps(applicationContext);
179-
List<GeneratedAndroidFirebaseCore.PigeonInitializeResponse> firebaseAppsList =
194+
List<GeneratedAndroidFirebaseCore.CoreInitializeResponse> firebaseAppsList =
180195
new ArrayList<>(firebaseApps.size());
181196

182197
for (FirebaseApp firebaseApp : firebaseApps) {
@@ -194,9 +209,9 @@ public void initializeCore(
194209

195210
@Override
196211
public void optionsFromResource(
197-
GeneratedAndroidFirebaseCore.Result<GeneratedAndroidFirebaseCore.PigeonFirebaseOptions>
212+
GeneratedAndroidFirebaseCore.Result<GeneratedAndroidFirebaseCore.CoreFirebaseOptions>
198213
result) {
199-
TaskCompletionSource<GeneratedAndroidFirebaseCore.PigeonFirebaseOptions> taskCompletionSource =
214+
TaskCompletionSource<GeneratedAndroidFirebaseCore.CoreFirebaseOptions> taskCompletionSource =
200215
new TaskCompletionSource<>();
201216

202217
cachedThreadPool.execute(
@@ -222,7 +237,7 @@ public void optionsFromResource(
222237
public void setAutomaticDataCollectionEnabled(
223238
@NonNull String appName,
224239
@NonNull Boolean enabled,
225-
GeneratedAndroidFirebaseCore.Result<Void> result) {
240+
GeneratedAndroidFirebaseCore.VoidResult result) {
226241
TaskCompletionSource<Void> taskCompletionSource = new TaskCompletionSource<>();
227242

228243
cachedThreadPool.execute(
@@ -237,14 +252,14 @@ public void setAutomaticDataCollectionEnabled(
237252
}
238253
});
239254

240-
listenToResponse(taskCompletionSource, result);
255+
listenToVoidResponse(taskCompletionSource, result);
241256
}
242257

243258
@Override
244259
public void setAutomaticResourceManagementEnabled(
245260
@NonNull String appName,
246261
@NonNull Boolean enabled,
247-
GeneratedAndroidFirebaseCore.Result<Void> result) {
262+
GeneratedAndroidFirebaseCore.VoidResult result) {
248263
TaskCompletionSource<Void> taskCompletionSource = new TaskCompletionSource<>();
249264

250265
cachedThreadPool.execute(
@@ -259,11 +274,11 @@ public void setAutomaticResourceManagementEnabled(
259274
}
260275
});
261276

262-
listenToResponse(taskCompletionSource, result);
277+
listenToVoidResponse(taskCompletionSource, result);
263278
}
264279

265280
@Override
266-
public void delete(@NonNull String appName, GeneratedAndroidFirebaseCore.Result<Void> result) {
281+
public void delete(@NonNull String appName, GeneratedAndroidFirebaseCore.VoidResult result) {
267282
TaskCompletionSource<Void> taskCompletionSource = new TaskCompletionSource<>();
268283

269284
cachedThreadPool.execute(
@@ -282,6 +297,6 @@ public void delete(@NonNull String appName, GeneratedAndroidFirebaseCore.Result<
282297
}
283298
});
284299

285-
listenToResponse(taskCompletionSource, result);
300+
listenToVoidResponse(taskCompletionSource, result);
286301
}
287302
}

0 commit comments

Comments
 (0)