feat: support float32 type #2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: xl 
rahul2393 added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run This reverts commit 5b493fa.
arawind added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run …ly supported yet in production
…nsupported tests.
arawind added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
arpan14 approved these changes Feb 23, 2024
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Mutation.java Show resolved Hide resolved
...-cloud-spanner/src/main/java/com/google/cloud/spanner/connection/DirectExecuteResultSet.java Show resolved Hide resolved
olavloite reviewed Feb 23, 2024
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Mutation.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/StructReader.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Type.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/Value.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITFloat32Test.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITFloat32Test.java Outdated Show resolved Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/it/ITFloat32Test.java Outdated Show resolved Hide resolved
...loud-spanner/src/test/resources/com/google/cloud/spanner/connection/it/CreateMusicTables.sql Outdated Show resolved Hide resolved
google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java Outdated Show resolved Hide resolved
Major change: Ensures that the new methods in interfaces do not break for older clients. Minor changes: remove double cast; remove dependency on Truth assertions; remove unnecessary logic in Mutations::isNaN
arawind added kokoro:force-run yoshi-kokoro removed the kokoro:force-run olavloite approved these changes Feb 26, 2024
Collaborator
olavloite left a comment
olavloite left a comment There was a problem hiding this comment.
LGTM (assuming that the test failure is unrelated)
arawind added the owlbot:run gcf-owl-bot bot removed the owlbot:run Contributor Author
| The cloud-devel failures are unrelated and all FLOAT32 integration tests have passed on cloud-devel. From https://source.cloud.google.com/results/invocations/3dd1b019-0668-4964-a2bc-512009d741ef: |
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 4, 2024
🤖 I have created a release *beep* *boop* --- ## [6.61.0](https://togithub.com/googleapis/java-spanner/compare/v6.60.1...v6.61.0) (2024-03-04) ### Features * Support float32 type ([#2894](https://togithub.com/googleapis/java-spanner/issues/2894)) ([19b7976](https://togithub.com/googleapis/java-spanner/commit/19b79764294e938ad85d02b7c0662db6ec3afeda)) ### Bug Fixes * Flaky test issue due to AbortedException. ([#2925](https://togithub.com/googleapis/java-spanner/issues/2925)) ([cd34c1d](https://togithub.com/googleapis/java-spanner/commit/cd34c1d3ae9a5a36f4d5516dcf7c3667a9cf015a)) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.27.0 ([#2935](https://togithub.com/googleapis/java-spanner/issues/2935)) ([f8f835a](https://togithub.com/googleapis/java-spanner/commit/f8f835a9da705605c492e232a58276c39d1d7e6c)) * Update dependency org.json:json to v20240303 ([#2936](https://togithub.com/googleapis/java-spanner/issues/2936)) ([1d7044e](https://togithub.com/googleapis/java-spanner/commit/1d7044e97d16f5296b7de020cd24b11cbe2a7df0)) ### Documentation * Samples and tests for backup Admin APIs and overall spanner Admin APIs. ([#2882](https://togithub.com/googleapis/java-spanner/issues/2882)) ([de13636](https://togithub.com/googleapis/java-spanner/commit/de1363645e03f46deed5be41f90ddfed72766751)) * Update all public documents to use auto-generated admin clients. ([#2928](https://togithub.com/googleapis/java-spanner/issues/2928)) ([ccb110a](https://togithub.com/googleapis/java-spanner/commit/ccb110ad6835557870933c95cfd76580fd317a16)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
TODO:
Un-ignore the float32 parameter tests that are waiting for a backend fix.