Skip to content

Commit 1a0d8d9

Browse files
committed
Comments addressed
1 parent 6ca3673 commit 1a0d8d9

File tree

1 file changed

+9
-26
lines changed

1 file changed

+9
-26
lines changed

django_spanner/introspection.py

Lines changed: 9 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -167,11 +167,8 @@ def get_relations(self, cursor, table_name):
167167
rc.UNIQUE_CONSTRAINT_NAME = ccu.CONSTRAINT_NAME
168168
WHERE
169169
tc.TABLE_SCHEMA=@schema_name AND tc.TABLE_NAME=@view_name
170-
""", params=[
171-
{"schema_name": schema_name},
172-
{"view_name": self.connection.ops.quote_name(table_name)}
173-
]
174-
)
170+
""", params={"schema_name": schema_name, "view_name": self.connection.ops.quote_name(table_name)}
171+
)
175172
return {
176173
column: (referred_column, referred_table)
177174
for (column, referred_column, referred_table) in results
@@ -202,11 +199,8 @@ def get_primary_key_column(self, cursor, table_name):
202199
ccu ON tc.CONSTRAINT_NAME = ccu.CONSTRAINT_NAME
203200
WHERE
204201
tc.TABLE_NAME=@table_name AND tc.CONSTRAINT_TYPE='PRIMARY KEY' AND tc.TABLE_SCHEMA=@schema_name
205-
""", params=[
206-
{"schema_name": schema_name},
207-
{"table_name": self.connection.ops.quote_name(table_name)}
208-
]
209-
)
202+
""", params={"schema_name": schema_name, "table_name": self.connection.ops.quote_name(table_name)}
203+
)
210204
return results[0][0] if results else None
211205

212206
def get_constraints(self, cursor, table_name):
@@ -233,10 +227,7 @@ def get_constraints(self, cursor, table_name):
233227
FROM
234228
INFORMATION_SCHEMA.CONSTRAINT_COLUMN_USAGE
235229
WHERE TABLE_NAME=@table AND TABLE_SCHEMA=@schema_name''',
236-
params=[
237-
{"table": quoted_table_name},
238-
{"schema_name": schema_name}
239-
]
230+
params={"table": quoted_table_name, "schema_name": schema_name}
240231
)
241232
for constraint, column_name in constraint_columns:
242233
if constraint not in constraints:
@@ -261,10 +252,8 @@ def get_constraints(self, cursor, table_name):
261252
FROM
262253
INFORMATION_SCHEMA.TABLE_CONSTRAINTS
263254
WHERE
264-
TABLE_NAME=@table AND TABLE_SCHEMA=@schema_name''', params=[
265-
{"table": quoted_table_name},
266-
{"schema_name": schema_name}
267-
]
255+
TABLE_NAME=@table AND TABLE_SCHEMA=@schema_name''',
256+
params={"table": quoted_table_name, "schema_name": schema_name}
268257
)
269258
for constraint, constraint_type in constraint_types:
270259
already_added = constraint in constraints
@@ -310,10 +299,7 @@ def get_constraints(self, cursor, table_name):
310299
idx.TABLE_NAME=@table AND idx.TABLE_SCHEMA=@schema_name
311300
ORDER BY
312301
idx_col.ORDINAL_POSITION
313-
""", params=[
314-
{"table": quoted_table_name},
315-
{"schema_name": schema_name}
316-
]
302+
""", params={"table": quoted_table_name, "schema_name": schema_name}
317303
)
318304
for (
319305
index_name,
@@ -371,10 +357,7 @@ def get_key_columns(self, cursor, table_name):
371357
rc.CONSTRAINT_NAME = ccu.CONSTRAINT_NAME
372358
WHERE
373359
tc.TABLE_NAME=@table AND tc.TABLE_SCHEMA=@schema_name
374-
""", params=[
375-
{"table": self.connection.ops.quote_name(table_name)},
376-
{"schema_name": schema_name}
377-
]
360+
""", params={"table": self.connection.ops.quote_name(table_name), "schema_name": schema_name}
378361
)
379362
key_columns.extend(cursor.fetchall())
380363
return key_columns

0 commit comments

Comments
 (0)