feat(x-goog-spanner-request-id): introduce AtomicCounter #1275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This change introduces AtomicCounter, a concurrency/thread-safe counter do deal with the multi-threaded nature of variables. It permits operations: * atomic_counter += 1 * value = atomic_counter + 1 * atomic_counter.value that'll be paramount to bringing in the logic for x-goog-spanner-request-id in much reduced changelists. Updates googleapis#1261 Carved out from PR googleapis#1264
product-auto-label bot added the api: spanner 
olavloite approved these changes Dec 19, 2024
olavloite added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run 
Contributor Author
| Thank you for the reivew and approval @olavloite! I've updated the tests too. Kindly please help me run the bots too. |
olavloite added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
olavloite added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run olavloite added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run 
aakashanandg pushed a commit to aakashanandg/python-spanner that referenced this pull request Jan 2, 2025
…1275) * feat(x-goog-spanner-request-id): introduce AtomicCounter This change introduces AtomicCounter, a concurrency/thread-safe counter do deal with the multi-threaded nature of variables. It permits operations: * atomic_counter += 1 * value = atomic_counter + 1 * atomic_counter.value that'll be paramount to bringing in the logic for x-goog-spanner-request-id in much reduced changelists. Updates googleapis#1261 Carved out from PR googleapis#1264 * Tests for with_request_id * chore: remove sleep * chore: remove unused import --------- Co-authored-by: Knut Olav Løite <koloite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change introduces AtomicCounter, a concurrency/thread-safe counter do deal with the multi-threaded nature of variables. It permits operations:
that'll be paramount to bringing in the logic for
x-goog-spanner-request-id in much reduced changelists.
Updates #1261
Carved out from PR #1264