feat: optimize the active init operation of zero-initialized memory of makeFieldInitializationInConstructor #2948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
KKiiim changed the title makeFieldInitializationInConstructormakeFieldInitializationInConstructor 
HerrCai0907 reviewed Sep 17, 2025
Member
HerrCai0907 left a comment
HerrCai0907 left a comment There was a problem hiding this comment.
optimization goal LGTM. But I think we should only check whether the field is straightly initialized by zero and ignore it.
MaxGraey reviewed Sep 17, 2025
HerrCai0907 pushed a commit to wasm-ecosystem/warpo that referenced this pull request Sep 19, 2025
HerrCai0907 pushed a commit to wasm-ecosystem/warpo that referenced this pull request Sep 23, 2025
Author
| @CountBleck Could you please have a look on this PR (^_^) |
CountBleck reviewed Sep 25, 2025
Member
CountBleck left a comment
CountBleck left a comment There was a problem hiding this comment.
This seems mostly okay, but I'm wondering what all the removed $~lib/arraybuffer/ArrayBufferView#set:buffer is about...what is that setter function supposed to be doing anyway?
I'd like @MaxGraey to sign off before merging.
HerrCai0907 reviewed Oct 11, 2025
HerrCai0907 pushed a commit to wasm-ecosystem/warpo that referenced this pull request Oct 11, 2025
Author
| @coderabbitai summary |
Author
| Ping @MaxGraey @CountBleck Thanks for review again |
Author
| Ping for review @MaxGraey @CountBleck @HerrCai0907 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reduce unnecessary zero-initialization memory in the constructor
According to wasm-spec, grown memories should initialized with value 0x00
I've read the contributing guidelines
I've added my name and email to the NOTICE file