Skip to content

fix: toggle when id is passed #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
carkod wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: toggle when id is passed #4385

carkod wants to merge 1 commit into from

Conversation

@carkod
Copy link
Contributor

@carkod carkod commented Sep 28, 2022 •
edited
Loading

This is my attempt to fix onChange not firing when toggle and id are passed, without breaking the previous fix for the click firing twice

To test visually, check the first radio example I created. We can remove it once things are well tested.

I can add tests if the fix is good
@carkod
fix: fire onChange handler when toggle and id are passed
3077ba7 
This commit attempts to fix onChange not firing when `id` is passed. Previouly, there was a fix to prevent two clicks from being fired by stopping propagation, but in my example I was able to prevent two clicks from being fired using `e.preventDefault`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@carkod