Skip to content

Conversation

@highsmithcodes
Copy link

create mobile styling for the general layout, currently this site is not mobile friendly.

@welcome
Copy link

welcome bot commented Jun 29, 2023

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Comment on lines +31 to +38
// Manually check the screen size and apply appropriate styles
const screenWidth = window.innerWidth
if (screenWidth <= 768) {
style.container.flexDirection = 'column'
style.menu.position = 'relative'
style.menu.width = '100%'
style.sidebarMain.marginLeft = '0%'
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@highsmithcodes we can't really on window there as it's unsafe for SSR 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants