Skip to content

Conversation

@lakshayv13
Copy link

@lakshayv13 lakshayv13 commented Jun 23, 2024

FIxed the issue #4464

@welcome
Copy link

welcome bot commented Jun 23, 2024

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@vercel
Copy link

vercel bot commented Jun 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
semantic-ui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 6:22pm
@codecov
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.50%. Comparing base (1623c8d) to head (2a663ef).

Additional details and impacted files
@@ Coverage Diff @@ ## master #4485 +/- ## ======================================= Coverage 99.50% 99.50% ======================================= Files 186 186 Lines 3465 3465 ======================================= Hits 3448 3448 Misses 17 17 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant