Fix: prevent out-of-bounds write in counting sort for strings #3065
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix : #3055
Description of Change
This fixes an out-of-bounds access in the string counting sort implementation located at
sorting/counting_sort_string.cpp. The previous implementation wrote into an emptystd::string(output) without pre-allocating it, which causes undefined behavior and potential crashes.Changes
countSortnow takesstd::string&(modify in-place).outputis pre-allocated to the input length.unsigned charwhen indexing the count array to avoid negative/undefined indexing.Testing
edge cases(empty string,single char).Checklist
Notes: