Skip to content

fix(afs): optional get() options, get() for docs, and zone work #1849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davideast merged 3 commits into from
Sep 4, 2018
Merged

fix(afs): optional get() options, get() for docs, and zone work #1849

davideast merged 3 commits into from
Sep 4, 2018

Conversation

@jamesdaniels
Copy link
Member

@jamesdaniels jamesdaniels commented Aug 31, 2018 •
edited
Loading

Checklist

  • Issue number for this PR: #nnn (required)
  • Docs included?: (yes/no; required for all API/functional changes)
  • Test units included?: (yes/no; required)
  • In a clean directory, yarn install, yarn test run successfully? (yes/no; required)

Description

  • get()'s options should be optional
  • Add get() to docs
  • get() should return to the Angular zone
  • Since it's Promise-based and doesn't have side-effects, create and use a new simplified runInZone operator

Code sample
@jamesdaniels jamesdaniels requested a review from davideast August 31, 2018 21:25
@jamesdaniels jamesdaniels changed the title fix(afs): get options are optional, zone work, and doc get fix(afs): optional get() options, get() for docs, and zone work Aug 31, 2018
davideast
davideast approved these changes Sep 4, 2018
View reviewed changes
Copy link
Collaborator

@davideast davideast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@davideast davideast merged commit 185943f into master Sep 4, 2018
@davideast davideast deleted the get_stuff branch September 4, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes

3 participants

@jamesdaniels @davideast @googlebot