Skip to content

Conversation

@vimanyu
Copy link
Contributor

@vimanyu vimanyu commented Apr 9, 2021

Firebase Android SDKs for Auth, Database, Storage, Functions do not require Google Play Services anymore.
https://firebase.google.com/docs/android/android-play-services

Removing checks for Google Play services for these products from the C++ SDK.
Tested by running integration tests on,

Addresses firebase/quickstart-unity#975

@vimanyu vimanyu requested review from a-maurice and chkuang-g April 9, 2021 19:47
@google-cla google-cla bot added the cla: yes label Apr 9, 2021
@vimanyu vimanyu requested a review from jonsimantov April 9, 2021 19:47
@vimanyu
Copy link
Contributor Author

vimanyu commented Apr 9, 2021

Not sure if we still need the App callback but I left it in there for now. Let me know if that can be safely removed too.

a-maurice
a-maurice previously approved these changes Apr 9, 2021
@jonsimantov
Copy link
Contributor

Not sure if we still need the App callback but I left it in there for now. Let me know if that can be safely removed too.

What do you mean by "App callback"?

Copy link
Contributor

@jonsimantov jonsimantov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an update to the readme file?

- General: Fixed rare crashes at application exit when destructors were
being executed
([#345](https://github.com/firebase/firebase-cpp-sdk/pull/345)).
- General: Removed checks for Google Play Services in C++ for Auth, Database,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General (Android):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it should be spelled "Google Play services" (with a lower-case "s")

@jonsimantov
Copy link
Contributor

Not sure if we still need the App callback but I left it in there for now. Let me know if that can be safely removed too.

What do you mean by "App callback"?

I figured out what you meant - those are needed for the Unity SDK to initialize the various C++ modules, I believe, and should be kept in place for now.

@jonsimantov jonsimantov merged commit 9e448d0 into main Apr 12, 2021
@jonsimantov jonsimantov deleted the feature/remove-google-play-requirement branch April 12, 2021 19:22
@firebase firebase locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3 participants