Update REST and wire protocol query params for startAfter, endBefore #6706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 202ac61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Size Report 1Affected Products
Test Logs |
Contributor
Size Analysis Report 1Affected Products
Test Logs |
tohhsinpei force-pushed the hsinpei/startafter-endbefore branch from 0bb32b2 to eb447a7 Compare tohhsinpei changed the title startAfter, endBeforestartAfter, endBefore tohhsinpei force-pushed the hsinpei/startafter-endbefore branch from eb447a7 to 724336d Compare 
Contributor
| This is a good opportunity to extend the syncpoint spec protocol and add a new test. We can update the parser here: And then add a few specs here: These tests validate that we raise the right events for listeners. |
jmwski reviewed Oct 20, 2022
Contributor
jmwski left a comment
jmwski left a comment There was a problem hiding this comment.
Thanks for this great cleanup!
tohhsinpei force-pushed the hsinpei/startafter-endbefore branch from 44df2b1 to 28911b5 Compare tohhsinpei force-pushed the hsinpei/startafter-endbefore branch from 28911b5 to e6b2bc4 Compare 
maneesht reviewed Oct 24, 2022
Contributor
Changeset File Check ✅
|
jmwski approved these changes Nov 10, 2022
maneesht reviewed Nov 10, 2022
tohhsinpei force-pushed the hsinpei/startafter-endbefore branch from ff2d932 to bb3c4ed Compare maneesht reviewed Nov 11, 2022
tohhsinpei changed the base branch from master to mtewani/fix-syncpoint-test-compare maneesht reviewed Nov 14, 2022
maneesht reviewed Nov 14, 2022
maneesht reviewed Nov 15, 2022
maneesht reviewed Nov 15, 2022
maneesht reviewed Nov 15, 2022
Base automatically changed from mtewani/fix-syncpoint-test-compare to master November 15, 2022 16:21
hsubox76 approved these changes Nov 18, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We now support
startAfterandendBeforeon our REST endpoints (b/207844859). We've also added the fieldssin("start is inclusive") andein("end is inclusive") to the wire protocol payload (https://github.com/firebase/firebase-server/pull/4006).These are the corresponding client-side updates. Note that we don't need to compute the successor or predecessor value anymore.
Note that CI checks will fail until the new NSS version is released.