- Notifications
You must be signed in to change notification settings - Fork 6
feat: add token type value for in search operator #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughInSearchOperatorDsl에 문자열 값을 받아들이는 두 가지 새로운 오버로드가 추가되었습니다(가변 인자 및 Iterable), 해당 동작을 검증하는 단위 테스트 두 건이 함께 추가되었습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
core/src/test/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDslTest.kt (1)
302-348: 문자열 value DSL 테스트는 적절하며, Iterable에 대한 추가 테스트를 고려할 수 있음단일 문자열과 복수 문자열에 대한 in 연산자 JSON 구조를 잘 검증하고 있어, 새
value(vararg value: String)오버로드 동작이 명확히 보장됩니다.추가로, 필요하다면
value(listOf("value1", "value2"))와 같이Iterable<String>오버로드를 직접 검증하는 테스트를 하나 더 두면 커버리지가 완전해집니다.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
core/src/main/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDsl.kt(1 hunks)core/src/test/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDslTest.kt(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
core/src/test/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDslTest.kt (3)
core/src/main/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/SearchOperator.kt (1)
in(169-169)core/src/main/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/SearchOperatorDsl.kt (1)
in(77-79)core/src/main/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDsl.kt (10)
value(65-67)value(75-78)value(86-88)value(96-99)value(107-109)value(117-120)value(128-130)value(138-141)value(149-151)value(159-162)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
.../kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDsl.kt Show resolved Hide resolved
9416a4b to 6dfd502 Compare
inflab-int left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
core/src/main/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDsl.kt (1)
143-162: String value 오버로드 구현이 기존 패턴과 잘 맞습니다 (Iterable 테스트는 선택적으로 추가 고려)
Boolean/Temporal/Number/ObjectId용 오버로드들과 동일한 방식으로String에 대해vararg+Iterable을 제공하고 있어 DSL 일관성이 좋습니다.@JvmName("valueStringIterable")도 기존valueObjectIdIterable등과 충돌 없이 의미가 잘 드러납니다.추가로, 현재 PR 설명 기준으로는
vararg String케이스만 테스트되고 있는 것처럼 보이는데, 가능하다면Iterable<String>(예:listOf("value1", "value2"))에 대한 단일 테스트도 하나 두면 회귀 방지에 도움이 될 것 같습니다. 기능상 필수는 아니라서 여유 있을 때만 고려하셔도 될 것 같습니다.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
core/src/main/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDsl.kt(1 hunks)core/src/test/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDslTest.kt(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- core/src/test/kotlin/com/github/inflab/spring/data/mongodb/core/aggregation/search/InSearchOperatorDslTest.kt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
https://www.mongodb.com/docs/atlas/atlas-search/operators-collectors/in/#in-operator
add token type value for in search operator
Summary by CodeRabbit
새로운 기능
✏️ Tip: You can customize this high-level summary in your review settings.