refactored everything separating the front from the backend and having projects for container creation and another one for tests #223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- addedusage of docker-maven-plugin to build the images - removed the helper copy thing from the backend - front is packaged as a war so it may be threated as a dependency and used in the pipeline - added a docker-compose file that may be removed later whenever I introduce the use of docker-compose-maven-plugin before and after integration or e2e tests. Those should be run in separated maven artifacts or later on in the reactor run -removed all the heroku and readme manual stuff--- maybe another maven artifact or a terraform thing... donno, have to read whatever those do
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
maybe not merging is a good idea because I've deleted things you are using for promoting the project but maybe we can discuss if this approach is more like it should be in a deployment pipeline or something