Fix & optimize gcd function #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
os-moussao commented Dec 9, 2023
os-moussao commented - Handle gcd of negative numbers
- Fix the case when one of the numbers is equal to zero
- Improve time complexity (from linear to logarithmic) using modulo instead of repeated subtractions
- Update unit tests to cover edge cases and different scenarios
- handle gcd of negative numbers - fix the case when one of the numbers is equal to zero, gcd(0, x) = absolute value of x - optimize using modulo instead of repeated subtractions
- add more tests to cover edge cases and different scenarios - delete incorrect test (gcd(1, 0) = 0)
Contributor Author
| Hello @loiane, would you like to review this PR? |
Owner
| Thanks for the PR @os-moussao! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.