- Notifications
You must be signed in to change notification settings - Fork 1.5k
[v2] Proof of Concept: monorepo, package split #1279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
KKonstantinov wants to merge 29 commits into modelcontextprotocol:main Choose a base branch from KKonstantinov:feature/v2-monorepo-setup
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
[v2] Proof of Concept: monorepo, package split #1279
KKonstantinov wants to merge 29 commits into modelcontextprotocol:main from KKonstantinov:feature/v2-monorepo-setup
+10,492 −9,673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
commit: |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way we can break this PR up somehow so that this is more reviewable? E.g. with using git mv to preserve history and provenance of files? As it is it'll be quite hard to verify correctness of the split.
… into feature/v2-monorepo-setup
Contributor Author
| EDITs:
TODOs still:
|
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Ideas, requests and plans for v2 of the SDK which will incorporate major changes and fixes
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proof of Concept: v2 monorepo, package split
Motivation and Context
v1of the sdk shipped both client and server in the same package, introducing extra dependencies to users who have a single concern (client or server only). Client and server packages are now split, depending on a sharedcorepackage.Additionally,
v1exported all files as the public API of the SDK, limiting the SDK ability to iterate internally while keeping backwards compatibility. Barrel files are now introduced as the single entrypoint to the SDK and defining the public API of the SDK.How Has This Been Tested?
Unit, integration tests
Breaking Changes
v2
Types of changes
Checklist
Additional context