Add a Collector for pg_stat_io. #1169
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…1158) * Update querySettings Error Return in Scrape If there are errors querying namespace mappings, the potential error from querySettings is obscured. Adding an immediate return if there are errors retreiving settings. Signed-off-by: Jonathan Bowe <jonathan@bowedev.com> * Improve Verbosity of queryNamespaceMappings Errors Previously if any errors were encountered by queryNamespaceMappings, only a count of those errors was returned - making debugging those errors harder than it needs to be. I'm changing this to immediately return nil if no errors are encountered, and otherwise an error will be formatted with each of the namespaces and what the error was for that namespace. Signed-off-by: Jonathan Bowe <jonathan@bowedev.com> * Simplify Error Message Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Jonathan Bowe <bowejonathan99@gmail.com> --------- Signed-off-by: Jonathan Bowe <jonathan@bowedev.com> Signed-off-by: Jonathan Bowe <bowejonathan99@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: Peter Nuttall <peter.nuttall@snowflake.com>
Docs: https://www.postgresql.org/docs/current/monitoring-stats.html#MONITORING-PG-STAT-IO-VIEW We use this in production. One problem is that the stats for a vacuum are reported when the vacuum ends, not continuously. Signed-off-by: Peter Nuttall <peter.nuttall@snowflake.com>
sfc-gh-pnuttall force-pushed the pg_stat_io branch from c1df2b3 to 7b9d0b0 Compare 
| Looking forward to this getting merged! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Docs: https://www.postgresql.org/docs/current/monitoring-stats.html#MONITORING-PG-STAT-IO-VIEW
We use this in production. One problem is that the stats for a vacuum are reported when the vacuum ends, not continuously.