Ensure collection of stats succeed in a maximum duration to avoid exhausting PG connections #1229
+101 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pierresouchay force-pushed the limit_max_duration_of_postgresql_connections_to_avoid_using_too_many_connections branch from 443e086 to 26a21a6 Compare **Context**: As explained in prometheus-community#1228, when database is very slow to answer, every call to prometheus exporter might consume a new connection and possibly consume all available connections **Solution**: Ensure a Context with a specified Timeout is specified, so the connection will end if duration of collection is too long Signed-off-by: Pierre Souchay <pierre.souchay@pelico.io>
pierresouchay force-pushed the limit_max_duration_of_postgresql_connections_to_avoid_using_too_many_connections branch 3 times, most recently from ba8c19c to 76203d5 Compare …should Signed-off-by: Pierre Souchay <pierre.souchay@pelico.io>
pierresouchay force-pushed the limit_max_duration_of_postgresql_connections_to_avoid_using_too_many_connections branch from 76203d5 to f588ca8 Compare …DME.md Signed-off-by: Pierre SOUCHAY <pierre.souchay@pelico.io>
pierresouchay changed the title pierresouchay changed the title 
sysadmind reviewed Dec 12, 2025
Signed-off-by: Pierre SOUCHAY <pierre.souchay@pelico.io>
Signed-off-by: Pierre SOUCHAY <pierre.souchay@pelico.io>
Signed-off-by: Pierre SOUCHAY <pierre.souchay@pelico.io>
…ns_to_avoid_using_too_many_connections
Author
| @sysadmind I think I addressed all of your concerns, thank you very much for the review |
sysadmind reviewed Dec 13, 2025
| c.collectFromConnection(inst, ch) | ||
| elapsed := time.Since(startTime) | ||
| | ||
| if elapsed <= timeoutForQuery { |
Contributor
There was a problem hiding this comment.
We also need to check that we did not take much longer than the timeout - certainly not as long as the query delay (looks like that's currently 30s in this test)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Context: As explained in #1228, when database is very slow to answer, every call to prometheus exporter might consume a new connection and possibly consume all available connections
Solution: Ensure a Context with a specified Timeout is specified, so the connection will end if duration of collection is too long
Will fix #1228