Skip to content

Add tests and refactor code smells for algorithms #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
nientbfx07802 wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add tests and refactor code smells for algorithms #63

nientbfx07802 wants to merge 3 commits into from

Conversation

@nientbfx07802
Copy link

@nientbfx07802 nientbfx07802 commented Dec 11, 2025

Summary

This PR adds comprehensive unit tests and refactors code smells across multiple algorithm implementations.

Changes

  • New Tests: Added test suites for BuySellStocks, ClosestBinarySearchTreeValue, RansomNote, and ShortestWordDistanceIII
  • Refactoring: Improved code quality in ShortestWordDistanceIII by extracting a boolean flag to reduce complexity and enhance readability

Details

Tests Added:

  • BuySellStocks: 5 test cases covering edge cases and profit calculations
  • ClosestBinarySearchTreeValue: 6 test cases for tree traversal and value proximity
  • RansomNote: 6 test cases for character availability validation
  • ShortestWordDistanceIII: 6 test cases for word distance calculations

Code Refactoring:

  • Simplified ShortestWordDistanceIII logic by introducing isSameWord boolean to reduce nested conditions
  • Improved code readability with clearer comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@nientbfx07802