Skip to content

rustdoc-search: use lowercase, non-normalized name for type search #126176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 1 commit into from
Jun 9, 2024
Merged

rustdoc-search: use lowercase, non-normalized name for type search #126176

bors merged 1 commit into from
Jun 9, 2024

Conversation

@notriddle
Copy link
Contributor

@notriddle notriddle commented Jun 8, 2024

The type name ID map has underscores in its names, so the query element should have them, too.

Fixes #125993
@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2024

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 8, 2024
@notriddle notriddle force-pushed the notriddle/fix-type-name-normalize branch 2 times, most recently from d16ddb6 to ff0c10c Compare June 8, 2024 22:37
@fmease
Copy link
Member

fmease commented Jun 9, 2024

@bors r+
@bors
Copy link
Collaborator

bors commented Jun 9, 2024

📌 Commit ff0c10c has been approved by fmease

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2024
@bors
Auto merge of rust-lang#126176 - notriddle:notriddle/fix-type-name-no…
a47d1e2 
…rmalize, r=fmease rustdoc-search: use lowercase, non-normalized name for type search The type name ID map has underscores in its names, so the query element should have them, too. Fixes rust-lang#125993
@bors
Copy link
Collaborator

bors commented Jun 9, 2024

⌛ Testing commit ff0c10c with merge a47d1e2...
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Jun 9, 2024

💔 Test failed - checks-actions
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2024
@fmease
Copy link
Member

fmease commented Jun 9, 2024 •
edited
Loading

Right, I guess we should make this a platform-agnostic test ^^'.

Min:

pub type pid_t = i32; pub fn get_pid() -> pid_t { 0 } pub fn set_pid(_: pid_t) {}

@rustbot author
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2024
@notriddle notriddle force-pushed the notriddle/fix-type-name-normalize branch from ff0c10c to f2d707d Compare June 9, 2024 17:35
@notriddle
Copy link
Contributor Author

notriddle commented Jun 9, 2024

Yeah. 🤦

@bors r=fmease
@bors
Copy link
Collaborator

bors commented Jun 9, 2024

📌 Commit f2d707d has been approved by fmease

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Jun 9, 2024
@jieyouxu
Rollup merge of rust-lang#126176 - notriddle:notriddle/fix-type-name-…
4f67f3c 
…normalize, r=fmease rustdoc-search: use lowercase, non-normalized name for type search The type name ID map has underscores in its names, so the query element should have them, too. Fixes rust-lang#125993
@jieyouxu jieyouxu mentioned this pull request Jun 9, 2024
Closed
@jieyouxu
Copy link
Member

jieyouxu commented Jun 9, 2024

Unfortunately this needs to x fmt.
@bors r-
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2024
@notriddle
rustdoc-search: use lowercase, non-normalized name for type search
8865b8c 
The type name ID map has underscores in its names, so the query element should have them, too.
@notriddle notriddle force-pushed the notriddle/fix-type-name-normalize branch from f2d707d to 8865b8c Compare June 9, 2024 18:56
@notriddle
Copy link
Contributor Author

notriddle commented Jun 9, 2024

@bors r=fmease
@bors
Copy link
Collaborator

bors commented Jun 9, 2024

📌 Commit 8865b8c has been approved by fmease

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2024
@jieyouxu jieyouxu mentioned this pull request Jun 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2024
@bors
Auto merge of rust-lang#126205 - jieyouxu:rollup-s64z5ng, r=jieyouxu
a70b2ae 
Rollup of 4 pull requests Successful merges: - rust-lang#126172 (Weekly `cargo update`) - rust-lang#126176 (rustdoc-search: use lowercase, non-normalized name for type search) - rust-lang#126190 (Autolabel run-make tests, remind to update tracking issue) - rust-lang#126194 (Migrate more things to `WinError`) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 1fb4805 into rust-lang:master Jun 9, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 9, 2024
@rust-timer
Unrolled build for rust-lang#126176
99f9c94 
Rollup merge of rust-lang#126176 - notriddle:notriddle/fix-type-name-normalize, r=fmease rustdoc-search: use lowercase, non-normalized name for type search The type name ID map has underscores in its names, so the query element should have them, too. Fixes rust-lang#125993
@notriddle notriddle deleted the notriddle/fix-type-name-normalize branch June 10, 2024 00:16
Folyd added a commit to Folyd/rust that referenced this pull request Jun 10, 2024
@Folyd
Sync with upstream rust-lang#126176
0b8ae16
Folyd added a commit to Folyd/rust that referenced this pull request Aug 27, 2024
@Folyd
Sync with upstream rust-lang#126176
38a8a77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

6 participants

@notriddle @rustbot @fmease @bors @rust-log-analyzer @jieyouxu