Add a sanity check in case of any duplicate nodes #149916
Merged
+7 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added A-query-system 
Collaborator
| rustbot has assigned @jdonszelmann. Use |
Contributor Author
Contributor
| r=me once CI is green |
Member
| @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request Dec 12, 2025
Add a sanity check in case of any duplicate nodes
rustbot added the S-waiting-on-perf This comment has been minimized.
This comment has been minimized.
Collaborator
| Finished benchmarking commit (932e85d): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -2.7%, secondary -4.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 472.42s -> 471.934s (-0.10%) |
rustbot removed the S-waiting-on-perf Member
| oh interesting, I did not expect this :o |
Contributor
| @bors r+ rollup |
Collaborator
bors added S-waiting-on-bors jhpratt added a commit to jhpratt/rust that referenced this pull request Dec 13, 2025
…petrochenkov Add a sanity check in case of any duplicate nodes A simple check in case compiler tries to encode a dep node twice like in rust-lang#141540. Also if we'd try to mark a red node as green as it may then create a bad `DepNodeIndex` like in rust-lang#148295. If it prevents rust-lang#141540 from emitting a faulty `dep-graph.bin` file via panic then it means you will be able to temporarily fix it by simply restarting cargo or rust-analyzer without cleaning up incremental cache.
bors added a commit that referenced this pull request Dec 13, 2025
Rollup of 11 pull requests Successful merges: - #145278 (Update `rustc_codegen_gcc` rotate operation document) - #148825 (Add SystemTime::{MIN, MAX}) - #148837 (Use `let...else` instead of `match foo { ... _ => return };` and `if let ... else return`) - #149177 (Add proper suggestion for associated function with unknown field) - #149843 (Inherit attributes in delegation) - #149860 (Fix: Prevent macro-expanded extern crates from shadowing extern arguments) - #149874 (Weak for Arc pointer is marked as DynSend/DynSync) - #149903 (Remove unused code in `cfg_old`) - #149911 (bootstrap: Don't pass an unused `--color` to compiletest) - #149916 (Add a sanity check in case of any duplicate nodes) - #149924 (`declare_lint_pass` for `INLINE_ALWAYS_MISMATCHING_TARGET_FEATURES`) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 13, 2025
Rollup of 10 pull requests Successful merges: - #145278 (Update `rustc_codegen_gcc` rotate operation document) - #148837 (Use `let...else` instead of `match foo { ... _ => return };` and `if let ... else return`) - #149177 (Add proper suggestion for associated function with unknown field) - #149843 (Inherit attributes in delegation) - #149860 (Fix: Prevent macro-expanded extern crates from shadowing extern arguments) - #149874 (Weak for Arc pointer is marked as DynSend/DynSync) - #149903 (Remove unused code in `cfg_old`) - #149911 (bootstrap: Don't pass an unused `--color` to compiletest) - #149916 (Add a sanity check in case of any duplicate nodes) - #149924 (`declare_lint_pass` for `INLINE_ALWAYS_MISMATCHING_TARGET_FEATURES`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit that referenced this pull request Dec 13, 2025
Rollup merge of #149916 - zetanumbers:double_node_sanity, r=petrochenkov Add a sanity check in case of any duplicate nodes A simple check in case compiler tries to encode a dep node twice like in #141540. Also if we'd try to mark a red node as green as it may then create a bad `DepNodeIndex` like in #148295. If it prevents #141540 from emitting a faulty `dep-graph.bin` file via panic then it means you will be able to temporarily fix it by simply restarting cargo or rust-analyzer without cleaning up incremental cache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
A simple check in case compiler tries to encode a dep node twice like in #141540.
Also if we'd try to mark a red node as green as it may then create a bad
DepNodeIndexlike in #148295.If it prevents #141540 from emitting a faulty
dep-graph.binfile via panic then it means you will be able to temporarily fix it by simply restarting cargo or rust-analyzer without cleaning up incremental cache.