How to combine this to one javascript Object?

Question

I have this Code, and it's working.

var URL = new Object(); URL.pattern = /https?:\/\/([^\/]*)\//; URL.current = window.location.href; URL.getCurrent = function(){ return this.current.match(this.pattern)[1]; }; var thisDomain = URL.getCurrent();

Now what I want is to put the dot notations into the object, how do I do that? I tried this, but it's showing undefined when I call URL.getCurrent().

function URL(){ this.pattern = /https?:\/\/([^\/]*)\//; this.current = window.location.href; this.getCurrent = function(){ return this.current.match(this.pattern)[1]; }; }

I hope someone can help me out.

I'm sorry guys, I didn't know that. I'll accept them from now on. =) — reitermarkus
– reitermarkus, Commented Aug 1, 2012 at 6:57

Robin Drexler · Accepted Answer · 2012-08-01 06:41:52Z

5

The easiest thing you could do, is putting it n an object literal.

http://jsfiddle.net/wJQb6/

var URL = { pattern: /https?:\/\/([^\/]*)\//, current: window.location.href, getCurrent: function () { return this.current.match(this.pattern)[1]; } } alert(URL.getCurrent());

answered Aug 1, 2012 at 6:41

Robin Drexler

4,4773 gold badges28 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Fabrício Matté Over a year ago

literal annotation for the win. I'm not sure what OP wants and this seems more like a rewrite of the original code, anyway this is much more effective and what OP is trying is most likely impossible (you can't access function objects' nested functions as you do for regular object).

reitermarkus Over a year ago

Hmm, already tried literal annotation, didn't work either. But now it's working!

reitermarkus Over a year ago

And yes, it is a rewrite of the original.

Bergi · Accepted Answer · 2012-08-01 06:48:15Z

function URL(){ this.pattern = /https?:\/\/([^\/]*)\//; this.current = window.location.href; this.getCurrent = function(){ return this.current.match(this.pattern)[1]; }; }

With this, you have an empty constructor. The function URL itself has no properties, you will need to create an instance:

var url = new URL; url.getCurrent();

Yet, I'd recommend the following constructor, which includes inheritance:

function URL(c){ this.current = c; } URL.prototype.pattern = /https?:\/\/([^\/]*)\//; URL.prototype.getCurrent = function(){ return this.current.match(this.pattern)[1]; }; // Usage: var url = new URL(window.location.href); url.getCurrent();

If you want a static object, just use an object literal:

var url = { pattern: /https?:\/\/([^\/]*)\//, current: window.location.href, getCurrent: function () { return this.current.match(this.pattern)[1]; } } url.getCurrent();

Alexander · Accepted Answer · 2012-08-01 06:40:39Z

1

You still need to instantiate.

var url = new URL;

answered Aug 1, 2012 at 6:40

Alexander

23.5k11 gold badges65 silver badges74 bronze badges

1 Comment

reitermarkus Over a year ago

Ok, now I know that. I guess everyone was a beginner once. =)

Julien Ch. · Accepted Answer · 2012-08-01 07:00:37Z

There is not static methods in javascript, but you can use a singleton.

var URL=new function (){ this.pattern = /https?:\/\/([^\/]*)\//; this.current = window.location.href; this.getCurrent = function(){ return this.current.match(this.pattern)[1]; }; };

That will allow you to have access to the URL proptotype and contructor if ever need them.

Mikhail Payson · Accepted Answer · 2012-08-01 06:53:00Z

If you need to use classic OOP You can do something like this:

function URL(){ /* constructor function */ } URL.prototype.pattern = /https?:\/\/([^\/]*)\//; URL.prototype.current = window.location.href; URL.prototype.getCurrent = function(){ return this.current.match(this.pattern)[1]; }; anURL = new URL(); var result = anURL.getCurrent();

We may consider it as a class declaration. If it still looks odd initialize the fields there :)

Collectives™ on Stack Overflow

How to combine this to one javascript Object?

5 Answers 5

3 Comments

1 Comment

1 Comment

Comments

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

3 Comments

1 Comment

1 Comment

Comments

3 Comments

Related