fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests. #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…od while retrying exceptions in unit tests. * For details on issue see - googleapis#2206
fix: prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests.
product-auto-label bot added size: xs 
rajatbhatta added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run rajatbhatta added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run 
olavloite approved these changes Feb 9, 2023
rajatbhatta approved these changes Feb 9, 2023
gcf-merge-on-green bot pushed a commit that referenced this pull request Feb 21, 2023
🤖 I have created a release *beep* *boop* --- ## [6.36.1](https://togithub.com/googleapis/java-spanner/compare/v6.36.0...v6.36.1) (2023-02-21) ### Bug Fixes * Prevent illegal negative timeout values into thread sleep() method while retrying exceptions in unit tests. ([#2268](https://togithub.com/googleapis/java-spanner/issues/2268)) ([ce66098](https://togithub.com/googleapis/java-spanner/commit/ce66098c7139ea13d5ea91cf6fbceb5c732b392d)) ### Dependencies * Update dependency com.google.api.grpc:proto-google-cloud-spanner-executor-v1 to v1.2.0 ([#2256](https://togithub.com/googleapis/java-spanner/issues/2256)) ([f0ca86a](https://togithub.com/googleapis/java-spanner/commit/f0ca86a0858bde84cc38f1ad8fae5f3c4f4f3395)) * Update dependency com.google.cloud:google-cloud-monitoring to v3.12.0 ([#2284](https://togithub.com/googleapis/java-spanner/issues/2284)) ([0be701a](https://togithub.com/googleapis/java-spanner/commit/0be701a8b59277f2cfb990a88e4f1dafcbafdd97)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.3.0 ([#2285](https://togithub.com/googleapis/java-spanner/issues/2285)) ([bb5d5c6](https://togithub.com/googleapis/java-spanner/commit/bb5d5c66e78812b943a85e0fd888e7021c11bde1)) * Update dependency com.google.cloud:google-cloud-trace to v2.11.0 ([#2286](https://togithub.com/googleapis/java-spanner/issues/2286)) ([3c80932](https://togithub.com/googleapis/java-spanner/commit/3c80932d577de0ea108e695d0a4e542fbfc01deb)) * Update dependency org.graalvm.buildtools:junit-platform-native to v0.9.20 ([#2280](https://togithub.com/googleapis/java-spanner/issues/2280)) ([685d1ea](https://togithub.com/googleapis/java-spanner/commit/685d1ea1c3bf59cd71093a68c260276c605d835f)) * Update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.20 ([#2281](https://togithub.com/googleapis/java-spanner/issues/2281)) ([f2aabc2](https://togithub.com/googleapis/java-spanner/commit/f2aabc24770d1b9c505dfc96b39fe81c6a0ad5a5)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
AbortedException, the retry delay is set as-1for the exception. Negative value is not an acceptable input toThread.sleep()method and hence we are gettingIllegalArgumentException. This is resulting in flaky unit test behaviour.